Opened 9 years ago
Closed 9 years ago
#25490 closed Cleanup/optimization (fixed)
Logout view can be cached by Safari
Reported by: | Kaleb Elwert | Owned by: | nobody |
---|---|---|---|
Component: | contrib.auth | Version: | 1.8 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Safari has a tendency to cache redirects, even when cookies are set. Unfortunately this means that sometimes visiting a logout view with a redirect will not log the user out.
https://github.com/django/django/pull/5379 contains a simple fix against the master branch, but currently no tests.
Attachments (1)
Change History (4)
by , 9 years ago
Attachment: | never-cache-logout.patch added |
---|
comment:1 by , 9 years ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Type: | Uncategorized → Cleanup/optimization |
By the way, if you provide a pull request, you don't need to also attach a patch on the ticket.
Note:
See TracTickets
for help on using tickets.
add @never_cache to django.contrib.auth.views.logout