Opened 9 years ago
Last modified 5 years ago
#25409 assigned New feature
Allow url and groups of urls to be easily tagged and selected
Reported by: | Atul Bhouraskar | Owned by: | Atul Bhouraskar |
---|---|---|---|
Component: | Core (URLs) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | barfieldsamueliii10@…, Atul Bhouraskar | Triage Stage: | Someday/Maybe |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
The Problem
Often (usually in middleware) processing has to be applied to a certain URLs only eg CORS.
The usual way to specify this would be to create an additional set of regex patterns identifying these urls - eg.
CORS_URLS_REGEX = r'^/api/.*$'
The middleware then typically matches the incoming request URL to the regex and determines whether it is to be selected for processing.
This approach has several limitations including:
- It violates DRY as the regexes in the settings have to be synced with the actual URL patterns
- Matching multiple patterns may require the app writer to essentially reinvent URL patterns - poorly.
The Proposal
Add an optional tags
keyword argument to django.conf.urls.url
allowing a URL to be optionally tagged with one or more tags which can then be retrieved via HttpRequest.resolver_match.tags
in the middleware / view etc.
urlpatterns = [ url(r'^$', views.home, name='home'), url(r'^articles/$', views.show_articles, name='show-articles', tags=['require_GET']), url(r'^private/$', include(private_patterns), tags=['login_required']), url(r'^api/', include(api_patterns), tags=[ 'cors_allowed', 'nologin_forbidden', 'ajax_required' ]), ]
In the example above, the home
url has no tags, the show-articles
url is tagged require_GET
, the urls under private/
are all tagged login_required
while the the urls under api/
have multiple tags.
This allows app middleware to selectively process urls very easily:
class LoginRequiredMiddleware(object): def process_view(self, request, view_func, view_args, view_kwargs): if 'login_required' in request.resolver_match.tags and \ not request.user.is_authenticated(): return redirect('login') class RequireGETMiddleware(object): def process_view(self, request, view_func, view_args, view_kwargs): if 'require_GET' in request.resolver_match.tags and request.method != 'GET': return HttpResponseNotAllowed(['GET']) class AjaxRequiredMiddleware(object): def process_view(self, request, view_func, view_args, view_kwargs): if 'ajax_required' in request.resolver_match.tags and not request.is_ajax(): return HttpResponseForbidden() class CorsMiddleware(object): def process_view(self, request, view_func, view_args, view_kwargs): if 'cors_allowed' in request.resolver_match.tags: # continue CORS processing
I am attaching a patch that implements this tagging feature to urlpatterns. It has tests (docs to be added). The change is fully backwards compatible as specifying tags is completely optional, all existing tests pass with the patch applied to master.
I'm working on my branch at https://github.com/atul-bhouraskar/django/tree/ticket_25409
Comments welcome!
Attachments (1)
Change History (11)
by , 9 years ago
Attachment: | urltags.patch added |
---|
comment:1 by , 9 years ago
Description: | modified (diff) |
---|---|
Owner: | changed from | to
Status: | new → assigned |
comment:2 by , 9 years ago
Triage Stage: | Unreviewed → Someday/Maybe |
---|
Hi, there is major work planned for URLs in 1.10. See the django-developers discussion. I am not sure if a similar concept might be part of that work, but we'll probably want to wait until that work is completed and merged before proceeding with this idea.
comment:3 by , 9 years ago
Hi Tim,
Thanks for looking at this. I've looked the URLs work planned for 1.10 but that has a different focus - of making it easy to extend the URL resolver and is proposing a new internal architecture. That is orthogonal to what we are talking about here.
Here we are not touching the core of the resolver but simply adding a mechanism to pass on tags from the pattern to the request via the resolver. The actual code changes are in 10 code lines most of which are simple assignments as the tags get passed to the final match object. The rest are tests. It would be easy to add it to the new architecture at any time.
Other than documentation (which I can add in pretty quickly) the patch can be easily merged in (unless there are design issues that need to be discussed which I am fine with).
comment:4 by , 9 years ago
Yes, it would be a good idea to raise the issue on the DevelopersMailingList for a design review. The main reason for waiting to merge until after the major work is completed is to avoid creating merge conflicts with that branch as a lot of code and documentation is being moved.
comment:5 by , 9 years ago
Hi, the major rework for URLs involves a different approach to the same problem. Instead of "tagging" urls and filtering for tags in the middleware, it allows you to apply decorators to a group of urls, i.e.:
from ... import login_required urlpatterns = [ ... url(r'^private/$', include(private_patterns), decorators=[login_required]), ]
This will apply the login_required
decorator to each view in private_patterns
. Most middleware that might be applied to a certain section of a site already has matching decorators, so this should give you pretty much the same options.
If you'd like to discuss your approach as an alternative, please raise the issue on the mailing list.
comment:6 by , 9 years ago
Cc: | added |
---|
comment:9 by , 9 years ago
PR for another proposal: url(r'^$', include('suburl'), wrap=[wrap1, wrap2])
.
comment:10 by , 5 years ago
Was this feature ever implemented? I'm looking for a way to disable caching for all admin urls.
Patch implementing url tagging.