Attributes are always set on `connection.features` (gis)

[Daniel Hahler]

With commit d9ff5ef36d3f714736d633435d45f03eac9c17b5 the behaviour of hasattr
on connection.features seems to have changed, e.g. the following will be True
now always, and was previously so only for Django < 1.5.

hasattr(connection.features, 'confirm')

pytest-django is using the following code:

# confirm() is not needed/available in Django >= 1.5
# See https://code.djangoproject.com/ticket/17760
if hasattr(self.connection.features, 'confirm'):
    self.connection.features.confirm()

The problem seems to be that __getattr__ should raise an AttributeError in this case.
(Source: ​https://github.com/django/django/commit/d9ff5ef36d3f714736d633435d45f03eac9c17b5#diff-fbce17c4cb97f431da78cbdf3ac4ff16R90)

[Claude Paroz]

Thanks for noticing that regression. Could you please add a test to the patch?

[Daniel Hahler]

Where should the test go?

[Tim Graham]

A new file called tests/gis_tests/test_backends.py seems reasonable to me.

[Daniel Hahler]

It might make sense to add a test for this for all backends?
(with pytest I could imagine using a parametrized test for this - which would access an existing and non-existing attribute).
Can this be done in Django's testing framework?

Apart from that, I think that it would be better/faster if somebody who is more used to Django's tests would add it.

(I am more used to tests based on pytest, and to be honest: the lack of proper attribution (in terms of Git authorship) for (several, but not all) previous patches from me makes me less motivated to go the last mile here, although that seems to get handled better by now - just saying).

[Tim Graham]

I think writing the test for the current backend being tested (e.g. checking hasattr(connection.features, 'nonexistent') is enough.

[Tim Graham <timograham@…>]

In da5747f8:

Fixed #25400 -- Fixed regression in nonexistent features on gis backends.