Opened 10 years ago

Closed 10 years ago

#25335 closed Bug (fixed)

QuerySet.iterator doesn't return an iterator any more

Reported by: Gavin Wahl Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Release blocker Keywords:
Cc: Loic Bistuer Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In django 1.8, QuerySet.iterator returns an iterator. In master, it returns an iterable. This is a regression introduced by 4c3bfe90 (#24211). The ModelIterator, ValuesListIterator, etc that that commit added are not actually iterators, they are iterables.

Change History (5)

comment:2 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 10 years ago

Cc: Loic Bistuer added
Triage Stage: Accepted → Ready for checkin

Loic, can you double check?

comment:4 by Loic Bistuer, 10 years ago

Looks good, +1.

comment:5 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 627c7eb7:

Fixed #25335 -- Fixed regression where QuerySet.iterator() didn't return an iterator.

Note: See TracTickets for help on using tickets.
Back to Top