Opened 9 years ago
Closed 9 years ago
#25335 closed Bug (fixed)
QuerySet.iterator doesn't return an iterator any more
Reported by: | Gavin Wahl | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Release blocker | Keywords: | |
Cc: | Loic Bistuer | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In django 1.8, QuerySet.iterator returns an iterator. In master, it returns an iterable. This is a regression introduced by 4c3bfe90 (#24211). The ModelIterator, ValuesListIterator, etc that that commit added are not actually iterators, they are iterables.
Change History (5)
comment:1 by , 9 years ago
Has patch: | set |
---|
comment:2 by , 9 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 9 years ago
Cc: | added |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Loic, can you double check?
Note:
See TracTickets
for help on using tickets.
https://github.com/django/django/pull/5222