Opened 9 years ago

Closed 9 years ago

#25308 closed Bug (fixed)

Initial migrations not created if no app provided and MIGRATION_MODULES[app] overridden

Reported by: Jeremy Satterfield Owned by: Jeremy Satterfield
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The makemigrations command will falsely return 'No changed detected.' if all of the following criteria are met:

  • No initial migration exists for the app in question, but models are defined
  • settings.MIGRATION_MODULES is used to change to location of the migrations for the app in question
  • No app is explicitly provided when running the makemigrations management command

This issue stems from the MigrationQuestioner.ask_initial not respecting the MIGRATION_MODULES setting.

Change History (4)

comment:1 by Jeremy Satterfield, 9 years ago

Owner: changed from nobody to Jeremy Satterfield
Status: new → assigned

comment:2 by Jeremy Satterfield, 9 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin
Version: 1.8 → master

comment:3 by Simon Charette, 9 years ago

Triage Stage: Ready for checkin → Accepted

Hi jsatt, thanks for the report and patch.

Please don't mark your own patch as RFC. Someone else has to review it and mark it so.

comment:4 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 1175027:

Fixed #25308 -- Made MigrationQuestioner respect MIGRATION_MODULES setting.

Note: See TracTickets for help on using tickets.
Back to Top