Opened 9 years ago

Closed 9 years ago

#25259 closed New feature (fixed)

Add Django version in a comment (hint) to auto-generated migration files

Reported by: Tyson Clugg Owned by: Tyson Clugg
Component: Migrations Version: dev
Severity: Normal Keywords: migrations
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Add a comment such as:

# Generated by Django 1.8.3 on 2015-08-11 16:50:15

This will help identify possible future compatibility issues with migrations.

Change History (10)

comment:1 by Markus Holtermann, 9 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Tyson Clugg, 9 years ago

Owner: changed from nobody to Tyson Clugg
Status: new → assigned

comment:4 by Tim Graham, 9 years ago

Patch needs improvement: set

in reply to:  4 comment:5 by Tyson Clugg, 9 years ago

Replying to timgraham:
Could you please elaborate as to what improvements you were expecting?

comment:6 by Claude Paroz, 9 years ago

At least tests should pass: ​http://djangoci.com/job/pull-requests-trusty/2966/

comment:7 by Tyson Clugg, 9 years ago

@claudep - the tests do pass as per my comment in the PR - build 2966 is against an old revision, 2973 is for the current revision and passes:

Tests at ​http://djangoci.com/job/pull-requests-trusty/2973/ show that revision ac9a6a5 passes.

I made the above comment in the PR as that's where all the other build results are shown, adding the exact same comment here seemed like redundant noise.

comment:8 by Markus Holtermann, 9 years ago

Patch needs improvement: unset

Updated PR: ​https://github.com/django/django/pull/5211

comment:9 by Tim Graham, 9 years ago

Triage Stage: Accepted → Ready for checkin

comment:10 by Markus Holtermann <info@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In e34226f:

Fixed #25259 -- Added comments to header of generated migration files

Note: See TracTickets for help on using tickets.
Back to Top