Opened 10 years ago

Closed 4 years ago

#25255 closed Bug (fixed)

Squashed migration is not marked as unapplied

Reported by: Markus Holtermann Owned by: Jacob Walls
Component: Migrations Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Markus Holtermann)

When unapplying a squashed migration and the replaced migration files are still around, the MigrationExecutor mark the squash migration as unapplied, too, not only the replaced migrations.

Change History (10)

comment:1 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Markus Holtermann, 10 years ago

Description: modified (diff)
Summary: MigrationExecutor.check_replacements() doesn't take care of unapplied migrations → Squashed migration is not marked as unapplied

While working on #24800 I realized that the issue is actually not fully correct. The squashed migration is not marked as applied.

Last edited 10 years ago by Tim Graham (previous) (diff)

comment:3 by Markus Holtermann, 10 years ago

Has patch: set

PR: ​https://github.com/django/django/pull/5280

comment:4 by Tim Graham, 10 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Tim Graham, 10 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

The commit this depends on is moved to "Work in progress" status, so moving this off the checkin queue.

comment:6 by Sasha Gaevsky, 10 years ago

Has patch: unset
Patch needs improvement: unset

Updated ticket, since original PR was closed.

comment:7 by Tim Graham, 10 years ago

Has patch: set
Patch needs improvement: set

"Has patch + Patch needs improvement" is the correct status.

comment:8 by Jacob Walls, 4 years ago

Owner: changed from nobody to Jacob Walls
Patch needs improvement: unset
Status: new → assigned

​PR

comment:9 by Mariusz Felisiak, 4 years ago

Triage Stage: Accepted → Ready for checkin

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In c0e29ce:

Fixed #25255 -- Recorded unapplied squashed migrations.

Note: See TracTickets for help on using tickets.
Back to Top