Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25206 closed Bug (fixed)

Incorrect error message when checking modeladmin fieldsets

Reported by: Alasdair Nicol Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: alasdair@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Arising from ​Stack Overflow question

The checks framework is showing the error message:

SystemCheckError: System check identified some issues:

ERRORS: : (admin.E008) The value of 'fieldsets[1]['fields']' must be a list or tuple.

It only has one index instead of two, in this case it should be fieldsets[3][1]['fields'].

The problem is that 'fieldsets[1]' is hardcoded, instead of using the label that describes the current fieldset.

Change History (4)

comment:1 by Alasdair Nicol, 10 years ago

Has patch: set

Pull request ​https://github.com/django/django/pull/5081

comment:2 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 89728182:

Fixed #25206 -- Fixed error message when checking a ModelAdmin fieldset's fields.

comment:4 by Tim Graham <timograham@…>, 10 years ago

In 7a846019:

[1.8.x] Fixed #25206 -- Fixed error message when checking a ModelAdmin fieldset's fields.

Backport of 8972818289452d611d97fac0f4a6d24625987b31 from master

Note: See TracTickets for help on using tickets.
Back to Top