Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25178 closed Cleanup/optimization (fixed)

Add DEFAULT_FROM_EMAIL to deployment checklist

Reported by: ronaldoldenburger Owned by: nobody
Component: Documentation Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

While using the PasswordResetForm I wasn't reminded that DEFAULT_FROM_EMAIL was a needed setting and was not set. This resulted in a non working PasswordResetForm and thus there was no email send. As I did had the SERVER_EMAIL set I thought this would be sufficient.

Attachments (1)

25178.diff​ (922 bytes ) - added by Tim Graham 10 years ago.

Download all attachments as: .zip

Change History (5)

by Tim Graham, 10 years ago

Attachment: 25178.diff​ added

comment:1 by Tim Graham, 10 years ago

I am not sure exactly where you propose to raise the exception, but if I understand correctly, it's probably not an option due to backwards compatibility as the "unset" option for DEFAULT_FROM_EMAIL is actually "webmaster@localhost".

How about the attached enhancement to the deployment checklist instead?

comment:2 by Tim Graham, 10 years ago

Component: Core (Mail) → Documentation
Has patch: set
Summary: Raise Exception when DEFAULT_FROM_EMAIL is not set → Add DEFAULT_FROM_EMAIL to deployment checklist
Triage Stage: Unreviewed → Ready for checkin
Type: Bug → Cleanup/optimization

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In ae32f32:

Fixed #25178 -- Added DEFAULT_FROM_EMAIL to deployment checklist.

comment:4 by Tim Graham <timograham@…>, 10 years ago

In fc279ed2:

[1.8.x] Fixed #25178 -- Added DEFAULT_FROM_EMAIL to deployment checklist.

Backport of ae32f324981dd64d7c04fcbed9d99356914a61de from master

Note: See TracTickets for help on using tickets.
Back to Top