Opened 9 years ago

Closed 9 years ago

#25155 closed Cleanup/optimization (fixed)

Move Style declaration out of the function

Reported by: Maciej Fijalkowski Owned by: nobody
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

as far as I can see Style class does not have to be in the function body. It makes stuff slow on PyPy.

Attachments (1)

x.patch​ (554 bytes ) - added by Maciej Fijalkowski 9 years ago.

Download all attachments as: .zip

Change History (3)

by Maciej Fijalkowski, 9 years ago

Attachment: x.patch​ added

comment:1 by Tim Graham, 9 years ago

Component: Uncategorized → Core (Management commands)
Has patch: set
Triage Stage: Unreviewed → Ready for checkin
Type: Uncategorized → Cleanup/optimization
Version: 1.8 → master

comment:2 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In 5cedef9:

Fixed #25155 -- Removed an inner class in core.management.color for PyPy performance.

Note: See TracTickets for help on using tickets.
Back to Top