Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25149 closed Cleanup/optimization (fixed)

Replace window.__admin_utc_offset__ with a data attribute

Reported by: Tim Graham Owned by: Tim Graham
Component: contrib.admin Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I don't think storing global variables on window is a best practice these days.

Change History (4)

comment:1 by Tim Graham, 10 years ago

Has patch: set

​PR

comment:2 by Aymeric Augustin, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 8eeb566a:

Fixed #25149 -- Replaced window.admin_utc_offset with a data attribute.

comment:4 by Tim Graham <timograham@…>, 10 years ago

In 0603f093:

Refs #25149 -- Fixed regression in admin datetime widget for timezones on the negative side of UTC.

Note: See TracTickets for help on using tickets.
Back to Top