Tests fails when using Pillow 2.9.0

[Yosuke Yasuda]

A test failed in python3.4.3

$ ./runtests.py ./forms_tests
Testing against Django installed in '/Users/yasudayousuke/oss_hack/django_dev/django_parent/django'
Creating test database for alias 'default'...
Creating test database for alias 'other'...
..................................................................................................................F.....................................................................................................................................................................................................................................................................................................................s...........
======================================================================
FAIL: test_imagefield_annotate_with_bitmap_image_after_clean (forms_tests.tests.test_fields.FieldsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/yasudayousuke/oss_hack/django_dev/django_parent/tests/forms_tests/tests/test_fields.py", line 862, in test_imagefield_annotate_with_bitmap_image_after_clean
    self.assertIsNone(uploaded_file.content_type)
AssertionError: 'image/bmp' is not None

Probably the cause is the change of library Pillow added few days ago.
​https://github.com/python-pillow/Pillow/commit/fe18b039ca9e11c6deed8f21a9e5eca815badbb7

My Pillow version is 2.9.0, so the content_type is "image/bmp" and is not None.

[Tim Graham]

The original purpose of this test is to check the case when Pillow doesn't detect the MIME type of the image, so we need to find a new case of that if possible.

[Yosuke Yasuda]

Replying to timgraham:

The original purpose of this test is to check the case when Pillow doesn't detect the MIME type of the image, so we need to find a new case of that if possible.

Then, should I choose a different type of image which Pillow doesn't detect the MIME type? Or can I set file extension which doesn't exist?

I searched Pillow. I found that it is merging the code that detect MIME type.
​https://github.com/python-pillow/Pillow/search?p=1&q=MIME&utf8=%E2%9C%93

So if I find an image type that Pillow doesn't detect now, the same kind of issue may happen later.

[Yosuke Yasuda]

I found a tga file can be ImageFile and its MIME type is not detected, so I changed bmp to tga.

[Andriy Sokolovskiy]

Yes, after previous ticket I added MIME for BMP, so it will fail.
I think it is better to use mock to model this situation instead of fixing every time after Pillow registers MIME for image plugin without it.

[Tim Graham <timograham@…>]

In a2b999d:

Fixed #25108 -- Fixed a test which failed on Pillow 2.9+

[Tim Graham <timograham@…>]

In 269315d8:

[1.8.x] Fixed #25108 -- Fixed a test which failed on Pillow 2.9+

Backport of a2b999dfcac9bc92513a36ec6b3033ded1561c66 from master