Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#25048 closed Cleanup/optimization (fixed)

Request headers that include underscore are missing from request META

Reported by: segalle Owned by: nobody
Component: Documentation Version: 1.8
Severity: Normal Keywords: request header meta
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When sending custom request header that include underscore string, it is removed from the META dict on the request

for example:
I send the header: CUSTOM_HEADER and cant see it in the server side.
if i remove the underscore (CUSTOMHEADER) it appears again in the META dict as HTTP_CUSTOMHEADER.

Attachments (1)

25048.diff​ (839 bytes ) - added by Tim Graham 9 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by Tim Graham, 9 years ago

This is by design, see 316b8d49746933d1845d600314b002d9b64d3e3d. Should we document it somewhere?

by Tim Graham, 9 years ago

Attachment: 25048.diff​ added

comment:2 by Tim Graham, 9 years ago

Component: HTTP handling → Documentation
Has patch: set
Triage Stage: Unreviewed → Accepted
Type: Bug → Cleanup/optimization

Proposed doc patch attached.

comment:3 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In 7b6d310:

Fixed #25048 -- Documented that runservers strips headers with underscores.

refs 316b8d49746933d1845d600314b002d9b64d3e3d

comment:4 by Tim Graham <timograham@…>, 9 years ago

In 340c410:

[1.8.x] Fixed #25048 -- Documented that runservers strips headers with underscores.

refs 316b8d49746933d1845d600314b002d9b64d3e3d

Backport of 7b6d3104f263d9483982928604b2e51f06126ec1 from master

Note: See TracTickets for help on using tickets.
Back to Top