Add request.user to the debug view

[Grigoriy Kramarenko]

Displays the username in the mail for admins (used in views.debug.ExceptionReporterFilter) that caused the error:

Request repr():
<HttpRequest
path:/somepath/,
USER:None,
GET:{'get-key': 'get-value'},
POST:{'post-key': 'post-value'},
COOKIES:{'post-key': 'post-value'},
META:{'post-key': 'post-value'}>

[Claude Paroz]

I think this is a nice addition. Would it be possible to transform the patch in a pull request?
We'll also need more tests (with anonymous user, authenticated user, custom user, etc.).

[Tim Graham]

Although it's a common pattern to set request.user, I had some reservations about coupling HttpRequest and contrib.auth when I first read this.

Sentry seems to have some way to associate exceptions with users. Maybe it would be worth looking at how they accomplish that?

[Grigoriy Kramarenko]

Replying to timgraham:

Although it's a common pattern to set request.user, I had some reservations about coupling HttpRequest and contrib.auth when I first read this.

Sentry seems to have some way to associate exceptions with users. Maybe it would be worth looking at how they accomplish that?

This decision does not depend on contrib.auth and request.user. But when there they - it is of great help to solve the problems of administrators.

Maybe need test with 2 options: with request.user and without it.

[Vlastimil Zíma]

Note, that build_request_repr was removed in #25099.

[Tim Graham]

It seems the new alternative would be to add it to views.debug.TECHNICAL_500_TEMPLATE and TECHNICAL_500_TEXT_TEMPLATE under "Request information".

[Julian Gindi]

Based on the latest comment, I'll move ahead with the mentioned implementation as opposed to continuing the work from the first patch. Does that sound right?

[Tim Graham]

Yes, the initial patch will no longer apply.

[John Moses]

Where should the associated test with this go?

[Tim Graham]

There are tests for the debug view in tests/view_tests/tests/test_debug.py.

[John Moses]

How does this look? ​https://github.com/django/django/pull/5381

[Tim Graham <timograham@…>]

In 2b6344e:

Fixed #25037 -- Added request.user to the debug view.