[patch] admin popup window stays open after adding and saving an item that has a primary_key=True field

[Gary Wilson <gary.wilson@…>]

I have the models:

class Semester(models.Model):
    name = models.CharField(maxlength=20, primary_key=True)

class Course(models.Model):
    number = models.CharField('course number', maxlength=6)
    title = models.CharField('course title', maxlength=100)
    semester = models.ForeignKey(Semester)
    year = models.PositiveIntegerField()

Steps to reproduce:

1. In the admin, click Courses.
2. Click add course.
3. Click plus next to Semester dropdown.
4. Fill in semester name.
5. Click save.

What happens:

• The add semester popup window goes blank.
• The add semester popup window does not close itself and must be closed manually.
• The new semester entry does get created in the database.
• The semester dropdown in the add course form does not get populated with the newly created semester like it should.

[deryck@…]

String primary key values must be quoted or JavaScript assumes it's a variable.

[deryck]

Change summary to indicate patch.

[Adrian Holovaty]

(In [3553]) Fixed #2500 -- Fixed bug in admin related-object pop-up window when using a primary key value that isn't an integer. Thanks, Gary Wilson and deryck@…

[Adrian Holovaty]

FYI, in the solution I came up with, I ended up just relying on the fact that the repr() of the primary-key value would be safely quoted -- so it works for integer and string values alike.

[Adrian Holovaty]

(In [3613]) Fixed bug in [3553] -- Changed admin JavaScript quoting for related-object popup window not to use repr(), because that produces values such as 123L for longints. Refs #2500