Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#24983 closed Cleanup/optimization (fixed)

"domain" in sites framework should clarify if it is a fully-qualified domain name

Reported by: mandm Owned by: bipsandbytes
Component: Documentation Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The documents on sites framework should clarify that the domain should be a "fully qualified domain name" or just the "domain name".

An example where things can be confusing:

I have a setup where all requests to non-www domain i.e. http://example.com are redirected (with status 301) to http://www.example.com by the webserver. Hence I've set my preferred site in google webmasters tool as www.example.com (as opposed to example.com). When I use the sitemap framework, the urls generated are http://example.com/abc which is incorrect in my case. This makes me think that the domain in sites framework should have been www.example.com (instead of example.com). This is not evident from the documentation.

Change History (6)

comment:1 by Tim Graham, 9 years ago

Easy pickings: set
Triage Stage: UnreviewedAccepted

Yes, I believe it should be fully-qualified. On djangoproject.com, for example, we have the domains docs.djangoproject.com and www.djangoproject.com.

comment:2 by bipsandbytes, 9 years ago

Owner: changed from nobody to bipsandbytes
Status: newassigned

comment:5 by Tim Graham <timograham@…>, 9 years ago

Resolution: fixed
Status: assignedclosed

In 34047b2:

Fixed #24983 -- Clarified contrib.sites Site.domain is fully qualified.

comment:6 by Tim Graham <timograham@…>, 9 years ago

In 6aa618ba:

[1.8.x] Fixed #24983 -- Clarified contrib.sites Site.domain is fully qualified.

Backport of 34047b23e284fd3459903294a5776b67c3e33ed9 from master

Note: See TracTickets for help on using tickets.
Back to Top