Opened 9 years ago

Closed 9 years ago

#24966 closed Cleanup/optimization (fixed)

Add deployment system check for empty ALLOWED_HOSTS setting

Reported by: Robert Roskam Owned by: Robert Roskam
Component: Core (Other) Version: 1.8
Severity: Normal Keywords: setting
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Allowed_Hosts is a required setting. When debug mode is off, and Allowed_Hosts is not implemented, this should raise an ImproperlyConfigured Error.

See conversation here: ​https://groups.google.com/forum/#!topic/django-developers/nIrbGjyOsNY

Change History (7)

comment:1 by Robert Roskam, 9 years ago

Owner: set to Robert Roskam
Status: new → assigned

comment:2 by Carl Meyer, 9 years ago

Component: Uncategorized → Core (Other)
Triage Stage: Unreviewed → Accepted

comment:3 by Robert Roskam, 9 years ago

Going to make it a warning instead of a hard fail. It's going in core/checks/security/base.py.

comment:4 by Tim Graham, 9 years ago

Has patch: set
Needs documentation: set
Needs tests: set

comment:5 by Seth Gottlieb, 9 years ago

Submitted a pull request to raiderrobert that adds documentation for his pull request.

comment:6 by Tim Graham, 9 years ago

Needs documentation: unset
Needs tests: unset
Summary: Unconfigured Allowed_Hosts Setting Should Raise ImproperlyConfigured Error → Add deployment system check for empty ALLOWED_HOSTS setting

comment:7 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In ed514cae:

Fixed #24966 -- Added deployment system check for empty ALLOWED_HOSTS.

Note: See TracTickets for help on using tickets.
Back to Top