Opened 5 years ago

Closed 5 years ago

#24935 closed Cleanup/optimization (fixed)

refactor conditional GET handling

Reported by: Denis Cornehl Owned by: Denis Cornehl
Component: HTTP handling Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Django has currently three different places where conditional GET is handled

  • ConditionalGetMiddleware
  • @condition (and so @etag and last_modified) decorators
  • CommonMiddleware

they all do it differently.

I want to refactor this into the same shared behavior.

This is a starting point to fix some related tickets and (most likely) deprecate and remove settings.USE_ETAGS

Change History (4)

comment:1 Changed 5 years ago by Denis Cornehl

Has patch: set
Owner: changed from nobody to Denis Cornehl
Status: newassigned

comment:2 Changed 5 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Tim Graham

Patch needs improvement: set

Feedback left on the pull request.

comment:4 Changed 5 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 7a40fef:

Fixed #24935 -- Refactored common conditional GET handling.

Note: See TracTickets for help on using tickets.
Back to Top