Opened 10 years ago
Last modified 10 years ago
#24933 new Cleanup/optimization
Make FormSet management forms optional
Reported by: | Patryk Zawadzki | Owned by: | nobody |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Pull Requests: | |||
Description (last modified by ) ¶
They are only required if the form class used consists of nothing but checkbox fields. Dealing with management forms makes it unnecessarily hard to dynamically alter the list of forms in front-end and forgetting to render one will result in the FormSet.__init__()
raising an exception.
I've submitted a discussion to the mailing list but I'm creating a ticket here to provide a pull request for people to play with to make an informed decision.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (3)
comment:1 by , 10 years ago
Has patch: | set |
---|
comment:2 by , 10 years ago
Description: | modified (diff) |
---|
comment:3 by , 10 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
Type: | Uncategorized → Cleanup/optimization |
Pull request: https://github.com/django/django/pull/4797