Opened 8 years ago

Closed 8 years ago

#24929 closed Cleanup/optimization (fixed)

permission_required decorator should take any iterable of permissions

Reported by: Raphael Michel Owned by: Raphael Michel
Component: contrib.auth Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Raphael Michel)

As it came up in the discussion on ticket #24914 on GitHub (​https://github.com/django/django/pull/4749#discussion_r31776720), there is no reason why permission_required only takes lists and tuples of permissions, while has_perms itself can take any iterable. To be consistent with the new mixins and other parts of Django where both strings and iterables of strings are accepted (see e.g. model._meta.ordering), we should change this logic. I will prepare a pull request with the same logic that is used in other places.

Change History (7)

comment:1 Changed 8 years ago by Raphael Michel

Description: modified (diff)
Has patch: set
Owner: set to Raphael Michel
Status: new → assigned
Summary: permission_required decorator should take any iterable if permissions → permission_required decorator should take any iterable of permissions

I created the pull request: ​https://github.com/django/django/pull/4790

comment:2 Changed 8 years ago by Moritz Sichert

Triage Stage: Unreviewed → Accepted

Looks good!

comment:3 Changed 8 years ago by Moritz Sichert

Needs documentation: set

Although I think you should add some documentation for this change.

comment:4 Changed 8 years ago by Marc Tamlyn

Needs tests: set
Patch needs improvement: set

comment:5 Changed 8 years ago by Raphael Michel

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

I added a regression test and changed one word in the documentation (list → iterable). Do you expect more documentation on this? If so, how? I don't see a proper place (or a need for it).

comment:6 Changed 8 years ago by Tim Graham

Triage Stage: Accepted → Ready for checkin

comment:7 Changed 8 years ago by Tim Graham <timograham@…>

Resolution: → fixed
Status: assigned → closed

In 39937de7:

Fixed #24929 -- Allowed permission_required decorator to take any iterable

Note: See TracTickets for help on using tickets.
Back to Top