Opened 9 years ago
Closed 9 years ago
#24899 closed Cleanup/optimization (fixed)
Split up migrations autodetector._detect_changes into separate functions
Reported by: | Markus Holtermann | Owned by: | Steadman |
---|---|---|---|
Component: | Migrations | Version: | dev |
Severity: | Normal | Keywords: | afraid-to-commit |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
The migration autodetector is one important part of Django's migration framework. The "magic" happens in its method _detect_changes()
which spans more than 200 lines of code. Although the method already has some structure, it would be great to move the different steps that are performed in there into separate methods.
Attachments (1)
Change History (6)
comment:1 Changed 9 years ago by
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 Changed 9 years ago by
Owner: | changed from nobody to Steadman |
---|---|
Status: | new → assigned |
Changed 9 years ago by
Attachment: | 0001-Fixes-24899.patch added |
---|
comment:3 Changed 9 years ago by
Triage Stage: | Accepted → Ready for checkin |
---|
Markus, please confirm PR is what you had in mind.
Note: See
TracTickets for help on using
tickets.
Proposed patch (passing all migration tests)