Opened 5 years ago

Closed 5 years ago

#24899 closed Cleanup/optimization (fixed)

Split up migrations autodetector._detect_changes into separate functions

Reported by: Markus Holtermann Owned by: Steadman
Component: Migrations Version: master
Severity: Normal Keywords: afraid-to-commit
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The migration autodetector is one important part of Django's migration framework. The "magic" happens in its method _detect_changes() which spans more than 200 lines of code. Although the method already has some structure, it would be great to move the different steps that are performed in there into separate methods.

Attachments (1)

0001-Fixes-24899.patch (9.0 KB) - added by Steadman 5 years ago.
Proposed patch (passing all migration tests)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Steadman

Owner: changed from nobody to Steadman
Status: newassigned

Changed 5 years ago by Steadman

Attachment: 0001-Fixes-24899.patch added

Proposed patch (passing all migration tests)

comment:3 Changed 5 years ago by Tim Graham

Triage Stage: AcceptedReady for checkin

Markus, please confirm PR is what you had in mind.

comment:4 Changed 5 years ago by Markus Holtermann

Yes, that's exactly what I had in mind. Thank you.

comment:5 Changed 5 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In ed63df3:

Fixed #24899 -- Split migrations autodetector._detect_changes() method

Note: See TracTickets for help on using tickets.
Back to Top