Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#24882 closed Cleanup/optimization (fixed)

Add documentation for Migration.run_before

Reported by: coolRR Owned by: Mark Henwood
Component: Documentation Version: 1.8
Severity: Normal Keywords:
Cc: Mark Henwood, Markus Holtermann Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Change History (12)

comment:1 Changed 3 years ago by Tim Graham

Description: modified (diff)
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

comment:2 Changed 3 years ago by Mark Henwood

Owner: changed from nobody to Mark Henwood
Status: newassigned

comment:4 Changed 3 years ago by Mark Henwood

Has patch: set

comment:5 Changed 3 years ago by Mark Henwood

Cc: Mark Henwood added

comment:6 Changed 3 years ago by Tim Graham

Patch needs improvement: set

comment:7 Changed 3 years ago by Markus Holtermann

Cc: Markus Holtermann added

comment:8 Changed 3 years ago by Mark Henwood

I've addressed all the helpful PR comments apart from this one, where instead I've explained why I disagree with the suggested alteration to my sentence:
https://github.com/django/django/pull/4775#discussion_r31799563

comment:9 Changed 3 years ago by Tim Graham

Patch needs improvement: unset

comment:10 Changed 3 years ago by Markus Holtermann

Triage Stage: AcceptedReady for checkin

LGTM. Do you mind some spell and grammar checking before committing, Tim.

comment:11 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In dee1bcd0:

Fixed #24882 -- Documented Migration.run_before

comment:12 Changed 3 years ago by Tim Graham <timograham@…>

In f4c09d3:

[1.8.x] Fixed #24882 -- Documented Migration.run_before

Backport of dee1bcd08a013ba5ffd8d1ec9b6628702f755066 from master

Note: See TracTickets for help on using tickets.
Back to Top