Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#24882 closed Cleanup/optimization (fixed)

Add documentation for Migration.run_before

Reported by: Ram Rachum Owned by: Mark Henwood
Component: Documentation Version: 1.8
Severity: Normal Keywords:
Cc: Mark Henwood, Markus Holtermann Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

Reference ​https://github.com/django/django/blob/c954931abd17f8efaa6b7662ac2916dbf47d2978/django/db/migrations/migration.py#L34-L37
Implemented in 5826dc52827254f44833acf678f429af94b4d636

Change History (12)

comment:1 by Tim Graham, 10 years ago

Description: modified (diff)
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

comment:2 by Mark Henwood, 10 years ago

Owner: changed from nobody to Mark Henwood
Status: new → assigned

comment:4 by Mark Henwood, 10 years ago

Has patch: set

comment:5 by Mark Henwood, 10 years ago

Cc: Mark Henwood added

comment:6 by Tim Graham, 10 years ago

Patch needs improvement: set

comment:7 by Markus Holtermann, 10 years ago

Cc: Markus Holtermann added

comment:8 by Mark Henwood, 10 years ago

I've addressed all the helpful PR comments apart from this one, where instead I've explained why I disagree with the suggested alteration to my sentence:
​https://github.com/django/django/pull/4775#discussion_r31799563

comment:9 by Tim Graham, 10 years ago

Patch needs improvement: unset

comment:10 by Markus Holtermann, 10 years ago

Triage Stage: Accepted → Ready for checkin

LGTM. Do you mind some spell and grammar checking before committing, Tim.

comment:11 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In dee1bcd0:

Fixed #24882 -- Documented Migration.run_before

comment:12 by Tim Graham <timograham@…>, 10 years ago

In f4c09d3:

[1.8.x] Fixed #24882 -- Documented Migration.run_before

Backport of dee1bcd08a013ba5ffd8d1ec9b6628702f755066 from master

Note: See TracTickets for help on using tickets.
Back to Top