Opened 10 years ago

Closed 10 years ago

#24846 closed Bug (fixed)

MySQL Migration SchemaEditor default code is ignorant of other blob/text data types

Reported by: Adam Johnson Owned by: Adam Johnson
Component: Migrations Version: 1.8
Severity: Normal Keywords: mysql migrations
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

#22424 added a default check for TextField and BinaryField, but it only checks for the longtext and longblob data types which Django uses for Text and Binary fields.

Some projects may be using custom field classes whose db_type is tinytext, mediumblob, etc. which are also subject to the same no-default rule, so the SchemaEditor should be made aware of that, otherwise migrations may break.

Change History (6)

comment:2 by Claude Paroz, 10 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 10 years ago

​PR

comment:4 by Claude Paroz, 10 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Tim Graham, 10 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

comment:6 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In e60cce4e:

Fixed #24846 -- Added support to MySQL SchemaEditor for all blob/text data types

Note: See TracTickets for help on using tickets.
Back to Top