Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#24716 closed Cleanup/optimization (fixed)

Deprecate Field._get_val_from_obj

Reported by: Thomas Stephenson Owned by: Thomas Stephenson
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Redundant method, called only by Field.value_to_string.

Change History (6)

comment:1 by Thomas Stephenson, 9 years ago

Owner: changed from ovangle@… to Thomas Stephenson
Status: new → assigned

comment:2 by Tim Graham, 9 years ago

Easy pickings: unset
Has patch: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization
Version: 1.8 → master

comment:3 by Tim Graham, 9 years ago

Patch needs improvement: set

comment:4 by Tim Graham, 9 years ago

Patch needs improvement: unset

​Updated PR

comment:5 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 035b0fa:

Fixed #24716 -- Deprecated Field._get_val_from_obj()

The method duplicates the functionality of Field.value_from_object()
and has the additional downside of being a privately named public
API method.

comment:6 by Tim Graham <timograham@…>, 7 years ago

In 733c7c7:

Refs #24716 -- Removed Field._get_val_from_obj() per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top