Opened 5 years ago

Closed 5 years ago

#24703 closed Cleanup/optimization (fixed)

Use MigrationLoader in squashmigrations

Reported by: Marten Kenbeek Owned by: Marten Kenbeek
Component: Migrations Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Just a small thing I noticed: squashmigrations creates a MigrationExecutor, but only ever uses the executor.loader attribute. It would be cleaner to directly use a MigrationLoader, same as in makemigrations and showmigrations.

Change History (4)

comment:1 Changed 5 years ago by Marten Kenbeek

Owner: changed from nobody to Marten Kenbeek
Status: newassigned

comment:2 Changed 5 years ago by Markus Holtermann

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Markus Holtermann

Triage Stage: AcceptedReady for checkin

comment:4 Changed 5 years ago by Markus Holtermann <info@…>

Resolution: fixed
Status: assignedclosed

In 1521861:

Fixed #24703 -- Changed squashmigrations to use a MigrationLoader

Changed squashmigrations to not instantiate a MigrationExecutor,
but to directly use a MigrationLoader instance instead.

Note: See TracTickets for help on using tickets.
Back to Top