Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#24672 closed Cleanup/optimization (fixed)

Remove postgis_topology creation from PostGIS install page

Reported by: Serhiy Owned by: nobody
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Why include "CREATE EXTENSION postgis_topology;" in https://docs.djangoproject.com/en/dev/ref/contrib/gis/install/postgis/ if it's useless for Django anyway?

Change History (8)

comment:1 by Tim Graham, 9 years ago

Discussion here. I don't know if Django might add some features for it in the future, but does the current note cause any harm?

comment:2 by Serhiy, 9 years ago

Unnecessary action that takes time and causes confusion.
It's so obvious to me that I can't even find the words to explain it. Why would you need a useless action in a tutorial? Adding the note _afterwards_ just causes a "what." reaction.

comment:3 by Serhiy, 9 years ago

Type: UncategorizedCleanup/optimization

comment:4 by Claude Paroz, 9 years ago

What about this:

  • docs/ref/contrib/gis/install/postgis.txt

    diff --git a/docs/ref/contrib/gis/install/postgis.txt b/docs/ref/contrib/gis/install/postgis.txt
    index 74c688f..c31ac71 100644
    a b spatial functionality::  
    6363    $ createdb  <db name>
    6464    $ psql <db name>
    6565    > CREATE EXTENSION postgis;
    66     > CREATE EXTENSION postgis_topology;
    6766
    68 No PostGIS topology functionalities are yet available from GeoDjango, so the
    69 creation of the ``postgis_topology`` extension is entirely optional.
     67GeoDjango itself does currently not leverage any of the `PostGIS topology
     68functionalities`__, but if you plan to use them at some point you can also
     69install the ``postgis_topology`` extension by issuing ``CREATE EXTENSION
     70postgis_topology;``.
     71
     72__ http://postgis.net/docs/Topology.html
    7073
    7174.. versionchanged:: 1.8
    7275

comment:5 by Serhiy, 9 years ago

Looks great to me.

comment:6 by Tim Graham, 9 years ago

Triage Stage: UnreviewedReady for checkin

Suggestion to simplify the wording a bit: "GeoDjango does not currently leverage any PostGIS topology functionality. If you plan to use those features at some point, you can also ..."

comment:7 by Claude Paroz <claude@…>, 9 years ago

Resolution: fixed
Status: newclosed

In 6e8cb75e:

Fixed #24672 -- Clarified note about installing postgis_topology

Thanks Serhiy Zahoriya for the suggestion and Tim Graham for the
review.

comment:8 by Claude Paroz <claude@…>, 9 years ago

In 99bf908:

[1.8.x] Fixed #24672 -- Clarified note about installing postgis_topology

Thanks Serhiy Zahoriya for the suggestion and Tim Graham for the
review.
Backport of 6e8cb75e3e from master.

Note: See TracTickets for help on using tickets.
Back to Top