TemporaryFileUploadHandler new_file() does not match its parent class

[David Danier]

TemporaryFileUploadHandler.new_file(self, file_name, *args, kwargs)
vs.
FileUploadHandler.new_file(self, field_name, file_name, content_type, content_length, charset=None, content_type_extra=None)

TemporaryFileUploadHandler.new_file will take "file_name" as its first argument and pass this (still as first argument) to FileUploadHandler.new_file. So the argument will end up FileUploadHandler.field_name, which is wrong.

I think a valid fix would be to remove file_name from TemporaryFileUploadHandler.new_file as the parameter is not used besides for calling the parent class. It may have been used for passing it to TemporaryUploadedFile, but this must be history. I'll attach a patch to change this.

[Claude Paroz]

Indeed, the parameter name is misleading, but this shouldn't lead to problems as the parameter is not used (this issue is there from 2008 and [d725cc9734272f867d41f7236235c28b3931a1b2]).
The patch looks good.

[David Danier]

[...] but this shouldn't lead to problems as the parameter is not used

It does lead to problems if you call TemporaryFileUploadHandler.new_file() with named parameters (kwargs). In this case you will pass mutiple values for the same argument when calling super(). Hit me here:
​https://github.com/ddanier/django-git-lfs/blob/master/django_git_lfs/views.py#L130
(Fixed this by only passing normal args)

[Claude Paroz <claude@…>]

In 9346e45f:

Fixed #24664 -- Removed misleading arg name from TemporaryFileUploadHandler.new_file