Allow usage of widgets (and maybe others) in GCBV (through ModelFormMixin)

[Markus Holtermann]

Generic class based views allow for fast development of basic views. Today I ran into a situation where I had to set a PasswordInput on a form field. But the only solution I found was creating an actual ModelForm and specifying it as form_class on the view.

I then created a patch that allows setting the widgets through the view:

django/views/generic/edit.py

@@ -120 +120 @@
     A mixin that provides a way to show and handle a modelform in a request.
     """
     fields = None
+    form_widgets = None
 
     def get_form_class(self):
         """
@@ -150 +151 @@
                     "the 'fields' attribute is prohibited." % self.__class__.__name__
                 )
 
-            return model_forms.modelform_factory(model, fields=self.fields)
+            return model_forms.modelform_factory(
+                model, fields=self.fields, widgets=self.get_form_widgets()
+            )
 
     def get_form_kwargs(self):
         """
@@ -161 +164 @@
             kwargs.update({'instance': self.object})
         return kwargs
 
+    def get_form_widgets(self):
+        return self.form_widgets
+
     def get_success_url(self):
         """
         Returns the supplied URL.

Usage:

class SomeCreateView(UpdateView):
    model = SomeModel
    fields = ['field1', 'field2', 'field3']                
    form_widgets = {
        'field3': forms.PasswordInput(render_value=True),
    }

[Tim Graham]

I don't think the possibility of saving a few lines of user code justifies the complexity of reimplementing the parameters to modelform_factory() as CBV parameters and methods.

[Tim Graham]

Feel free to raise it on the DevelopersMailingList for some more opinions.

[Tim Graham]

​django-developers discussion