Opened 10 years ago
Last modified 10 years ago
#24562 closed Cleanup/optimization
Test failure: Pickleability — at Initial Version
| Reported by: | Shai Berger | Owned by: | nobody |
|---|---|---|---|
| Component: | Utilities | Version: | 1.8 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Following the version bump to 1.8.1, we have failures on test_unsupported_unpickle (queryset_pickle.tests.PickleabilityTestCase) and test_unsupported_unpickle (model_regress.test_pickle.ModelPickleTestCase). The problem is arguably in the test code: Both tests assume that django.utils.version.get_major_version() returns a x.y string, but that is only true for .0 minor versions -- and so the tests broke on the version bump to 1.8.1.
I'm not quite sure about the fix -- django.utils.version.get_major_version() looks like a public interface but it is not documented as far as I could see; it hasn't changed in a long time, but its return value is unintuitive, and I would expect the same as the author(s) of these tests.