django.utils.version.get_major_version() does not return the major version

[Shai Berger]

django.utils.version.get_major_version() should returns a x.y string, that is what we call a major version. It does that only for the ".0" versions -- It returns "1.8" for 1.8, and "1.8.1" for 1.8.1.

I'm not quite sure about the fix -- django.utils.version.get_major_version() looks like a public interface but it is not documented. Now that the tests have been fixed, its only use in the Django code base is in the same file (from get_version()).

Should we just make it private?

[Tim Graham]

​PR

[Shai Berger]

I see that the PR is already merged, so there are no longer test failures and what's left is not a release blocker.

I updated the summary and description to focus on the issues left.

[Tim Graham]

Sorry, you created the ticket after I submitted the PR and I forgot to update the commit message. Anyway, yes, I think we could just revert the addition of the get_major_version() method as it was added in the same commit as the tests that used it (42736ac8e8c31137131714013951249a09e6e7d4).

[Tim Graham]

Well, it might be useful to leave the method but rename it to reflect its behavior: ​PR.

[Tim Graham <timograham@…>]

In ad532130:

Fixed #24562 -- Renamed get_major_version() to get_main_version()

This reflects the actual behavior of the method.