Opened 7 years ago

Closed 7 years ago

Last modified 20 months ago

#24474 closed New feature (fixed)

Make display for null fields in Django admin configurable through settings

Reported by: Loek van Gent Owned by: Loek van Gent
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Change History (18)

comment:1 Changed 7 years ago by Loek van Gent

Owner: changed from nobody to Loek van Gent
Status: newassigned

comment:2 Changed 7 years ago by Loek van Gent

Component: Uncategorizedcontrib.admin

comment:3 Changed 7 years ago by Tim Graham

Triage Stage: UnreviewedAccepted
Type: UncategorizedNew feature
Version: 1.7master

By settings, I think attributes of ModelAdmin and AdminSite would probably be the way to go.

comment:4 Changed 7 years ago by Loek van Gent

Needs documentation: set
Needs tests: set

comment:5 Changed 7 years ago by Loek van Gent

Has patch: set
Needs documentation: unset
Needs tests: unset

comment:6 Changed 7 years ago by Tim Graham

Patch needs improvement: set

Reviewed PR.

comment:7 Changed 7 years ago by Loek van Gent

Applied suggested changes. PR ready for new review.

comment:8 Changed 7 years ago by Tim Graham

Patch needs improvement: unset

comment:9 Changed 7 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 72f769f4:

Fixed #24474 -- Allowed configuring the admin's empty change list value.

comment:10 Changed 7 years ago by Tim Graham <timograham@…>

In 1273a7a0:

Revert "Fixed #24474 -- Allowed configuring the admin's empty change list value."

This reverts commit 72f769f494822981db6df9524b92a2d86f8e69fe.

There are several test failures that need to be fixed.

comment:11 Changed 7 years ago by Tim Graham

Patch needs improvement: set
Resolution: fixed
Status: closednew

comment:12 Changed 7 years ago by Loek van Gent

I see the failing tests now. I'll look into this.

comment:13 Changed 7 years ago by Loek van Gent

Django Sprint Cardiff! I'm continuing this ticket now.

comment:14 Changed 7 years ago by Loek van Gent

Status: newassigned

comment:15 Changed 7 years ago by Tim Graham

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

Looks good, pending a cosmetic comment.

comment:17 Changed 7 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 0207bdd:

Fixed #24474 -- Allowed configuring the admin's empty change list value.

comment:18 Changed 20 months ago by GitHub <noreply@…>

In 67a1ae6:

Refs #24474 -- Changed AdminSite.empty_value_display property to an attribute.

This was implemented with a property getter and setter when introduced
in 0207bdd2d4157c542c981264c86706b78ca246e9.

There is nothing special occurring here though - a simple read from and
assign to the underlying private attribute.

Note: See TracTickets for help on using tickets.
Back to Top