TemplateSyntaxError with {% cycle "Hello, how are you?" "Fine!" %}

[Carsten Fuchs]

Originating thread at django-users: ​https://groups.google.com/forum/#!topic/django-users/hSqSVpWMDqs

Using Django 1.7.5, there is a problem with commas in string literals in the cycle tag, e.g. with

    {% cycle "Hello, how are you?" "Fine!" %}

Please consider this example in the management shell (newlines added for clarity):

>>> from django.template import *
>>> t = Template('''{% cycle "Hello, how are you?" "Fine!" %}''')

/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/base.py:290: RemovedInDjango18Warning: 'The `cycle` template tag is changing to escape its arguments; the non-autoescaping version is deprecated. Load it from the `future` tag library to start using the new behavior.
  compiled_result = compile_func(self, token)

Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/base.py", line 132, in __init__
    self.nodelist = compile_string(template_string, origin)
  File "/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/base.py", line 162, in compile_string
    return parser.parse()
  File "/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/base.py", line 290, in parse
    compiled_result = compile_func(self, token)
  File "/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/defaulttags.py", line 648, in cycle
    values = [parser.compile_filter(arg) for arg in args[1:]]
  File "/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/base.py", line 372, in compile_filter
    return FilterExpression(token, self)
  File "/home/carsten/.virtualenvs/Ze/local/lib/python2.7/site-packages/django/template/base.py", line 588, in __init__
    "from '%s'" % (token[upto:], token))
TemplateSyntaxError: Could not parse the remainder: 'Hello"' from '""Hello"'

(Probably not relevant, but fyi, this happens with or without {% load cycle from future %}.)

[Tim Graham]

I confirmed the suspection on the mailing list that this is caused by those particular arguments being parsed using the legacy syntax. I'll use this as an excuse to deprecate that syntax.

[Tim Graham]

​PR

[Collin Anderson]

I agree deprecation makes sense.

[Baptiste Mispelon]

LGTM

[Tim Graham <timograham@…>]

In c36b60836be9e78ab877566cc43dc03960ce944d:

Fixed #24451 -- Deprecated comma-separated {% cycle %} syntax.

[Tim Graham <timograham@…>]

In 47201371:

Refs #24451 -- Corrected Django version for {% cycle %} deprecation.

[Tim Graham <timograham@…>]

In 27b23217:

Refs #24451 -- Removed comma-separated {% cycle %} syntax per deprecation timeline.