#24439 closed Bug (fixed)
make_object_list attribute mis-used in GCBV Documentation
| Reported by: | jambonrose | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.7 |
| Severity: | Normal | Keywords: | generic class-based-views |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The attribute make_object_list is defined in BaseYearArchiveView, on line 445 of `django/views/generic/dates.py`.
The only class to inherit from BaseYearArchiveView is YearArchiveView (on line 485 of the same file). Therefore, the only two classes where the make_object_list are BaseYearArchiveView and YearArchiveView.
However, in addition to the two classes above, the reference documentation uses the make_object_list attribute on examples of:
MonthArchiveViewWeekArchiveViewDayArchiveViewTodayArchiveView
In these instances, the attribute will have no effect, but is misleading, and should be removed.
Change History (5)
comment:1 by , 9 years ago
| Has patch: | set |
|---|
comment:2 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In fea45eff5a2f2ad10b2788603db80e5a4fe6be06: