Opened 11 years ago

Closed 11 years ago

#24417 closed New feature (fixed)

Add ModelAdmin.get_list_select_related()

Reported by: Anshuman Aggarwal Owned by: Loek van Gent
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since other list options such as list_display has a corresponding dynamic function such as get_list_display, select_related should have the same to dynamically specify the related models to retrieve.

Use case: If you dynamically include foreign key columns in list_display, then you would like the ability to dynamically specify the select_related also. Otherwise the queries are not as efficient as select_related allows them to be.

Change History (6)

comment:1 by Anshuman Aggarwal, 11 years ago

Type: Uncategorized → Bug

Marking as a bug since it feels that the API is inconsistent with the rest and its an easy win.

comment:2 by Tim Graham, 11 years ago

Component: Uncategorized → contrib.admin
Summary: Django admin opton get_list_select_related is missing → Add ModelAdmin.get_list_select_related()
Triage Stage: Unreviewed → Accepted
Type: Bug → New feature
Version: 1.7 → master

comment:3 by Loek van Gent, 11 years ago

Owner: changed from nobody to Loek van Gent
Status: new → assigned

comment:4 by Marten Kenbeek, 11 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Collin Anderson, 11 years ago

Has patch: set

comment:6 by Tim Graham <timograham@…>, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 35b3158:

Fixed #24417 -- Added ModelAdmin.get_list_select_related()

Note: See TracTickets for help on using tickets.
Back to Top