#24376 closed Cleanup/optimization (fixed)
UUIDField doesn't take a verbose_name positional arg
| Reported by: | Michael Angeletti | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 1.8alpha1 |
| Severity: | Normal | Keywords: | 1.8-beta |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Looking at https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2372, UUIDField doesn't take a positional argument, which is inconsistent with the behavior of other fields (the exception being relationship fields). Since UUIDField will surely be used for more than just a primary key replacement in some cases, it might be worth preserving this consistency. If you core devs are ok with this, I'll make a patch.
Thoughts?
Change History (9)
comment:1 by , 9 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | Uncategorized → Cleanup/optimization |
comment:2 by , 9 years ago
| Keywords: | 1.8-beta added |
|---|
comment:4 by , 9 years ago
| Has patch: | set |
|---|
comment:5 by , 9 years ago
| Needs tests: | set |
|---|
Could you please complement the existing test for verbose names: tests/model_fields/tests.py, BasicFieldTests.test_field_verbose_name?
comment:7 by , 9 years ago
| Needs tests: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
comment:8 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Sure!