Opened 4 years ago

Closed 4 years ago

#24349 closed Cleanup/optimization (fixed)

Limit URL domain name labels to 63 characters

Reported by: Anoop Thomas Mathew Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords: gTLD, email validation
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Newly added gTLDs can be longer upto 63 characters. Need to accommodate for that as well while validating the email.

Ref: http://en.wikipedia.org/wiki/Domain_Name_System#cite_ref-rfc1034_1-2

Change History (3)

comment:1 Changed 4 years ago by Tim Graham

Patch needs improvement: set
Summary: Support domain names with gTLDs like .consulting, .company, .website etcLimit URL domain name labels to 63 characters
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

Unless I made a mistake in reviewing this... as noted on the pull request, these domains seem to validate just fine. The proposed regex does limit TLDs to 63 characters per the RFC which could be useful.

comment:2 Changed 4 years ago by Tim Graham

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 24003295:

Fixed #24349 -- Limited domain name labels to 63 characters in EmailValidator

Note: See TracTickets for help on using tickets.
Back to Top