Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#24345 closed Bug (fixed)

Sitemap tests fail because of domain mismatch

Reported by: Marten Kenbeek Owned by: Marten Kenbeek
Component: contrib.sitemaps Version: master
Severity: Normal Keywords: 1.8-beta
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Marten Kenbeek)

This seems to be the result of moving the contrib tests into django/tests/, it works fine on 197dd4b8f12164f6acebb3b959f9ac2040a40400. It pre-dates commit e8cf4f8abec87b9da6ed8e5c8cf833af9b27f4dd, as the commit before that gets the same failures. Most sitemaps_tests fail because the expected result (example.com) and the actual response (testserver) have mismatching domain names, but only when run with all other tests. I haven't been able to isolate yet which exact combination of tests causes this.

There's probably something wrong with the tests themselves.

Change History (7)

comment:1 Changed 4 years ago by Marten Kenbeek

Description: modified (diff)

comment:2 Changed 4 years ago by Tim Graham

Easy pickings: set
Keywords: 1.8-beta added
Triage Stage: UnreviewedAccepted

I suspect a similar fix as e0b3926026984dccc86a09c0c4f32e8bec6f3fe1 will be needed. To reproduce this: ./runtests contenttypes_tests sitemaps_tests

comment:3 Changed 4 years ago by Marten Kenbeek

Has patch: set
Owner: changed from nobody to Marten Kenbeek
Status: newassigned

comment:4 Changed 4 years ago by Marten Kenbeek

Yes, that fixes the issue.

comment:5 Changed 4 years ago by Tim Graham

Triage Stage: AcceptedReady for checkin

comment:6 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In f668bac9d223408627ca92b2281cf7110039510b:

Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests; refs #11505

comment:7 Changed 4 years ago by Tim Graham <timograham@…>

In bc2eb6bfef00fd8ea4395e3462366b6571f88601:

[1.8.x] Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests; refs #11505

Backport of f668bac9d223408627ca92b2281cf7110039510b from master

Note: See TracTickets for help on using tickets.
Back to Top