Document that you cannot use @admin.register() with an __init__() super call that references the class name

[Anshuman Aggarwal]

When registering a django admin using the

@admin.register(XXXX)
class XXXXAdmin(admin.ModelAdmin):
    def __init__(self, *args, **kwargs):
        super(XXXXAdmin, self).__init__(*args, **kwargs)

gives an exception:

NameError: global name XXXXXAdmin is not defined

[Simon Charette]

Because of the way model admin registration and class decoration works I doubt we'll be able to fix this in an elegant way.

I suggest we document to use site.register if you have to reference your model admin during its initialization phase or simply use super().__init__ on Python 3.

[Anshuman Aggarwal]

Sounds like an unacceptable solution for now (I can confirm it works). The Python3 super may be a reasonable solution in the very long term.

[Tim Graham]

​PR

[Simon Charette]

LGTM

[Tim Graham <timograham@…>]

In 4cd2bdae:

Fixed #24323 -- Documented @admin.register can't be used with super(XXXAdmin in init().

[Tim Graham <timograham@…>]

In 5ebf6fd8:

[1.8.x] Fixed #24323 -- Documented @admin.register can't be used with super(XXXAdmin in init().

Backport of 4cd2bdae07ac5561fdae0eede58c68df4dfcc780 from master

[Tim Graham <timograham@…>]

In 76aa4cc:

[1.9.x] Fixed #24323 -- Documented @admin.register can't be used with super(XXXAdmin in init().

Backport of 4cd2bdae07ac5561fdae0eede58c68df4dfcc780 from master