admin.views.decorators.staff_member_required can't be used with decorator syntax and extra arguments

[andrei kulakov]

When a valid argument is given to staff_member_required decorator, it raises this confusing error:

staff_member_required() takes at least 1 argument (1 given)

  @staff_member_required(redirect_field_name='test')
  def v1(request):
      return HttpResponse("hi")

[Carl Meyer]

The issue here is simply that staff_member_required is not written to be automatically either a decorator or decorator-factory: it always requires a view_func as its first positional argument. So it simply doesn't support the way you are trying to use it; if you want to provide extra options to it, you can no longer use it with @ syntax.

If we are documenting it and making it public API, it should probably work like login_required, which would make your code work.

[Collin Anderson]

#24253 is about making staff_member_required a public api.

[John Giannelos]

I pushed a branch with a fix for that ticket here:
​https://github.com/johngian/django/tree/ticket_24294

---

Apparently there was already a pull request for that, sorry for the confusion.

[Simon Charette]

Can you point to the existing pull request?

This will also require a test.

[Tim Graham <timograham@…>]

In 08572e8d125da204fab230be5d1fdcc5d8d22256:

Fixed #24294 -- Allowed staff_member_required decorator to handle args.