Opened 9 years ago

Closed 9 years ago

#24285 closed Cleanup/optimization (fixed)

get_admin_log template tag doesn't work without for_user parameter

Reported by: Yair Chuchem Owned by: nobody
Component: contrib.admin Version: 1.7
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The get_admin_log template tag from django.contrib.admin.templatetags.log does not work when not using it's "for_user" option (which is being used in the default admin site index.html template)

Change History (5)

comment:2 by Tim Graham, 9 years ago

Easy pickings: unset
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted
Type: Bug → Cleanup/optimization

comment:3 by Yair Chuchem, 9 years ago

I'd call it a bug, although minor. The tag causes a TypeError when used as described in its documentation (which provides the "{% get_admin_log 10 as admin_log %}" example), although minor because that use case isn't used in the default admin site templates.

comment:4 by Yair Chuchem, 9 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In eb5ebcc2:

Fixed #24285 -- Made for_user argument optional for {% get_admin_log %} tag

Note: See TracTickets for help on using tickets.
Back to Top