Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#24250 closed Bug (fixed)

Class FormMixin does not provide "form" variable in centext.

Reported by: 4544fa8d Owned by: nobody
Component: Documentation Version: 1.7
Severity: Normal Keywords: FormMixin form context
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Class FormMixin does not provide "form" variable in centext. Documentation states that it should

​https://docs.djangoproject.com/en/1.7/ref/class-based-views/mixins-editing/#formmixin

Change History (12)

by Tim Graham, 10 years ago

Attachment: 24250.diff​ added

comment:1 by Tim Graham, 10 years ago

Component: Generic views → Documentation
Has patch: set
Triage Stage: Unreviewed → Accepted

Added a patch to correct the documentation.

Other errors corrected:

  • get_context_data() is not implemented on the mixin.
  • The sentence "Views mixing FormMixin must provide an implementation of form_valid and form_invalid." doesn't make sense as these methods have default implementations on the mixin.

comment:2 by Claude Paroz, 10 years ago

get_context_data() is inherited from ContextMixin (which only adds the view in the context). Does this warrants its presence in FormMixin docs?

comment:3 by Tim Graham, 10 years ago

Triage Stage: Accepted → Ready for checkin

Yes, I'll add that. Thanks for the review.

comment:4 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 5d193d042a3cc49033f0e8b5125913650d779496:

Fixed #24250 -- Corrected mistakes in FormMixin docs.

comment:5 by Tim Graham <timograham@…>, 10 years ago

In 9316a04a9cb8e2f57068c1655c18510f943120e4:

[1.6.x] Fixed #24250 -- Corrected mistakes in FormMixin docs.

Backport of 5d193d042a3cc49033f0e8b5125913650d779496 from master

comment:6 by Tim Graham <timograham@…>, 10 years ago

In 6454716264163b4693c03168ec56ea894ea511f2:

[1.8.x] Fixed #24250 -- Corrected mistakes in FormMixin docs.

Backport of 5d193d042a3cc49033f0e8b5125913650d779496 from master

comment:7 by Tim Graham <timograham@…>, 10 years ago

In 9c456ea8ff49eb8323f0b776935444197b6d75f2:

[1.7.x] Fixed #24250 -- Corrected mistakes in FormMixin docs.

Backport of 5d193d042a3cc49033f0e8b5125913650d779496 from master

comment:8 by Tim Graham <timograham@…>, 10 years ago

In 9a391fbd6102176d576aa96ed3aeee9e9661b455:

Fixed broken links in class based views flattend index; refs #24250.

comment:9 by Tim Graham <timograham@…>, 10 years ago

In 5fdd74f4be4aa6ce54021492e1b05ebf3770463d:

[1.8.x] Fixed broken links in class based views flattend index; refs #24250.

Backport of 9a391fbd6102176d576aa96ed3aeee9e9661b455 from master

comment:10 by Tim Graham <timograham@…>, 10 years ago

In 346451164e56b01d8174bb21e3354f47db2764ae:

[1.7.x] Fixed broken links in class based views flattend index; refs #24250.

Backport of 9a391fbd6102176d576aa96ed3aeee9e9661b455 from master

comment:11 by Tim Graham <timograham@…>, 10 years ago

In 5104d935045c85d6e3a7354dcb74b5009e5794f2:

[1.6.x] Fixed broken links in class based views flattend index; refs #24250.

Backport of 9a391fbd6102176d576aa96ed3aeee9e9661b455 from master

Note: See TracTickets for help on using tickets.
Back to Top