#24250 closed Bug (fixed)
Class FormMixin does not provide "form" variable in centext.
| Reported by: | 4544fa8d | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.7 |
| Severity: | Normal | Keywords: | FormMixin form context |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Class FormMixin does not provide "form" variable in centext. Documentation states that it should
https://docs.djangoproject.com/en/1.7/ref/class-based-views/mixins-editing/#formmixin
Attachments (1)
Change History (12)
by , 9 years ago
| Attachment: | 24250.diff added |
|---|
comment:1 by , 9 years ago
| Component: | Generic views → Documentation |
|---|---|
| Has patch: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 9 years ago
get_context_data() is inherited from ContextMixin (which only adds the view in the context). Does this warrants its presence in FormMixin docs?
comment:3 by , 9 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Yes, I'll add that. Thanks for the review.
comment:4 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Added a patch to correct the documentation.
Other errors corrected:
get_context_data()is not implemented on the mixin.FormMixinmust provide an implementation ofform_validandform_invalid." doesn't make sense as these methods have default implementations on the mixin.