Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#24219 closed Cleanup/optimization (fixed)

Deprecate django.forms.extras and move SelectDateWidget with the other widget.

Reported by: Loic Bistuer Owned by: Loic Bistuer
Component: Forms Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The content of django.forms.extras has hardly changed since it was introduced and SelectDateWidget is its only member, let's keep all widgets together and deprecate that package.

The tests/forms_tests/tests/test_extra.py has accumulated a bunch of misplaced tests and needs cleaning up too.

Change History (7)

comment:1 by Loic Bistuer, 9 years ago

Has patch: set
Owner: changed from nobody to Loic Bistuer
Status: new → assigned

PR ​https://github.com/django/django/pull/3986.

comment:2 by Simon Charette, 9 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 9 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Loic Bistuer <loic.bistuer@…>, 9 years ago

In 3a4c9e1b43ff67b6cf4c59da757666d6ac5ce4a0:

Cleaned up some forms tests.

Thanks Berker Peksag and Tim Graham for the reviews. Refs #24219.

comment:5 by Loic Bistuer <loic.bistuer@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 728b6fd9ca8624271f072d5f4618dc3fd38e87f1:

Fixed #24219 -- Moved SelectDateWidget together with the other widgets
and deprecated django.forms.extras.

Thanks Berker Peksag and Tim Graham for the reviews.

comment:6 by Tim Graham <timograham@…>, 9 years ago

In 59c3a140:

Refs #24219 -- Removed inaccurate sentence after move of SelectDateWidget.

comment:7 by Tim Graham <timograham@…>, 7 years ago

In 742d666:

Refs #24219 -- Removed django.forms.extras per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top