#24205 closed Cleanup/optimization (fixed)
Remove or deprecate weak parameter to Signal.disconnect()
| Reported by: | Tim Graham | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The parameter has no effect. I'm in favor of simply removing it and documenting it as a backwards incompatible change. A deprecation seems to simply add overhead. A library that attempts to support multiple versions of Django can remove the parameter without any backwards compatibility concerns. Any opposition to that?
Change History (5)
comment:1 by , 9 years ago
| Has patch: | set |
|---|---|
| Patch needs improvement: | set |
comment:2 by , 9 years ago
The deprecation doesn't cost us much, and as the weak disconnect parameter is documented, I think we should deprecate it.
comment:4 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
PR from Florian which implements a deprecation.