Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#24205 closed Cleanup/optimization (fixed)

Remove or deprecate weak parameter to Signal.disconnect()

Reported by: Tim Graham Owned by: nobody
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The parameter has no effect. I'm in favor of simply removing it and documenting it as a backwards incompatible change. A deprecation seems to simply add overhead. A library that attempts to support multiple versions of Django can remove the parameter without any backwards compatibility concerns. Any opposition to that?

Change History (5)

comment:1 by Tim Graham, 10 years ago

Has patch: set
Patch needs improvement: set

​PR from Florian which implements a deprecation.

comment:2 by Claude Paroz, 10 years ago

The deprecation doesn't cost us much, and as the weak disconnect parameter is documented, I think we should deprecate it.

comment:3 by Tim Graham, 10 years ago

Patch needs improvement: unset

​Updated PR

comment:4 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 16ee52d21d6835302bcd5ee594c5d6a0ef22d138:

Fixed #24205 -- Deprecated Signal.disconnect weak parameter.

comment:5 by Tim Graham <timograham@…>, 8 years ago

In 03087f8:

Refs #24205 -- Removed Signal.disconnect()'s weak argument.

Per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top