contrib.staticfiles does not respect override_settings
Various parts of the staticfiles storages and finders do not respect changes to the related settings when using the override_settings
or settings
context manager in the test suite. This is handled in Django's own test suite by clearing the lru_cache
and staticfiles_storage
in the BaseStaticFilesTestCase.setUp
. Ideally this would be handled by registering signal handlers for setting_changed
as is done for DEFAULT_FILE_STORAGE
, MEDIA_ROOT
, etc for the uploaded media settings.
Change History
(7)
Summary: |
contrib.staticfiles does not resepect override_settings → contrib.staticfiles does not respect override_settings
|
Component: |
Testing framework → contrib.staticfiles
|
Triage Stage: |
Unreviewed → Accepted
|
Type: |
Uncategorized → Cleanup/optimization
|
Version: |
1.7 → master
|
Owner: |
changed from nobody to Mark Lavin
|
Status: |
new → assigned
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
PR is ready for review: https://github.com/django/django/pull/3985