Deprecate django.templatetags.static

[Kristian Glass]

As far as I can see, since django.contrib.staticfiles was merged in, there's no reason to use django.templatetags.static and plenty of reasons not to (e.g. it makes assumptions about the existence of STATIC_URL)

The fact it provides a tag of the same name as the "correct" tag from staticfiles doesn't help either.

Could it be deprecated?

(And if I wanted to follow up with an accompanying PR, should I be using RemovedIn110Warning or RemovedIn20Warning (the latter of which has several instances, but surprises me slightly)

[Kristian Glass]

Ok, RemovedIn20Warning, thanks apollo13

[Kristian Glass]

Ah, I've just noticed this is used by admin; this PR is getting more fun!

[Kristian Glass]

So django.contrib.admin.templatetags.admin_static tries to use django.contrib.staticfiles.templatetags.staticfiles if the app's there, otherwise falls back to django.templatetags.static.

Can anyone provide guidance as to "improved" behaviour there please? Is there any kind of policy against apps from contrib depending on one another? Is it reasonable for d.c.admin to assume/require d.c.staticfiles? If the latter, can anyone point me to an existing example so I can crib from its mechanisms please? - d.c.auth depends on d.c.sessions, will crib appropriately

[Tim Graham]

I don't see much advantage here vs. the pain this is likely to cause (force everyone to use contrib.staticfiles and {% load static %} in their templates. The documentation points users in the direction IMO. There has been some talk of "if we did it again, static files might have been better in core, rather than contrib", but I'm not sure if that's something that's worth changing at this point. See also #18942. Feel free to raise the issue on the DevelopersMailingList or reopen if you think I've missed something here.