Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#24183 closed Bug (fixed)

Bad comparison in Substr function

Reported by: Claude Paroz Owned by: Josh Smeaton
Component: Database layer (models, ORM) Version: 1.8alpha1
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The following line in django/db/models/functions.py:

    if not hasattr('length', 'resolve_expression')

should be:

    if not hasattr(length, 'resolve_expression')

Change History (3)

comment:1 by Josh Smeaton, 11 years ago

Easy pickings: set
Has patch: set
Owner: changed from nobody to Josh Smeaton
Status: new → assigned
Triage Stage: Accepted → Ready for checkin

​https://github.com/django/django/pull/3954

comment:2 by Josh Smeaton <josh.smeaton@…>, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 61c102d010ef480cebe576cc1576d1101975925c:

Fixed #24183 -- Fixed wrong comparisons in Substr

comment:3 by Josh Smeaton <josh.smeaton@…>, 11 years ago

In 504cd5d3be450376f462b66e36df6edc923e9496:

[1.8.x] Fixed #24183 -- Fixed wrong comparisons in Substr

Backport of 61c102d010ef480cebe576cc1576d1101975925c from master

Note: See TracTickets for help on using tickets.
Back to Top