Opened 6 years ago

Closed 6 years ago

#24124 closed Cleanup/optimization (fixed)

Review the list of default context processors

Reported by: Aymeric Augustin Owned by: Collin Anderson
Component: Template system Version: master
Severity: Normal Keywords: multiple-template-engines
Cc: cmawebsite@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the settings file generated by the default project template, TEMPLATES contains a list of template context processors.

Currently this list is the same as the default TEMPLATE_CONTEXT_PROCESSORS. This doesn't seem optimal. For instance, the request context processor is missing.

We should think a bit about what the correct default value is. See this django-developers discussion.

Attachments (1)

24124-complement.diff (7.4 KB) - added by Aymeric Augustin 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 6 years ago by Collin Anderson

Cc: cmawebsite@… added
Has patch: set
Owner: changed from nobody to Collin Anderson
Status: newassigned
Last edited 6 years ago by Collin Anderson (previous) (diff)

comment:3 Changed 6 years ago by Collin Anderson <cmawebsite@…>

Resolution: fixed
Status: assignedclosed

In 26a92619f62aeb6f60e15c62e8322c96744eff26:

Fixed #24124 -- Changed context_processors in the default settings.py

comment:4 Changed 6 years ago by Aymeric Augustin

Resolution: fixed
Status: closednew

Sorry for reopening, but I think the tests should use the new recommended default, for consistency. See attached diff.

Changed 6 years ago by Aymeric Augustin

Attachment: 24124-complement.diff added

comment:5 Changed 6 years ago by Aymeric Augustin <aymeric.augustin@…>

Resolution: fixed
Status: newclosed

In 5f7230e12f0d237cdc19d8930006b0fc7d9dbaa6:

Fixed #24124 (again) -- Updated tests with new default context_processors.

Thanks Collin for the review.

Note: See TracTickets for help on using tickets.
Back to Top