Opened 10 years ago
Closed 10 years ago
#24124 closed Cleanup/optimization (fixed)
Review the list of default context processors
| Reported by: | Aymeric Augustin | Owned by: | Collin Anderson |
|---|---|---|---|
| Component: | Template system | Version: | dev |
| Severity: | Normal | Keywords: | multiple-template-engines |
| Cc: | cmawebsite@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the settings file generated by the default project template, TEMPLATES contains a list of template context processors.
Currently this list is the same as the default TEMPLATE_CONTEXT_PROCESSORS. This doesn't seem optimal. For instance, the request context processor is missing.
We should think a bit about what the correct default value is. See this django-developers discussion.
Attachments (1)
Change History (6)
comment:1 by , 10 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 10 years ago
| Cc: | added |
|---|---|
| Has patch: | set |
| Owner: | changed from to |
| Status: | new → assigned |
comment:3 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 by , 10 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
Sorry for reopening, but I think the tests should use the new recommended default, for consistency. See attached diff.
by , 10 years ago
| Attachment: | 24124-complement.diff added |
|---|
comment:5 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
https://github.com/django/django/pull/3897