Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#24019 closed Bug (fixed)

Docs inaccurately claim aggregation doesn't work with GenericRelation

Reported by: Shai Berger Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This ticket collects a few documentation issues:

  • Following #24002:
    • Release notes
    • Consider documenting the behavior of filtering on the generic relation
  • Fix the note on GenericRelations and aggregation (they do work now)

Change History (5)

comment:1 Changed 5 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 4 years ago by Tim Graham

Has patch: set
Summary: Documentation of GenericRelation should be updatedDocs inaccurately claim aggregation doesn't work with GenericRelation

The note about aggregation not working was in response to #10870 which has been fixed since 1.6 at least.

PR to address that.

I'm not sure release notes or further documentation is needed for #24002, that just looks like a bug fix to me.

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In e19bd086:

Fixed #24019 -- Fixed inaccurate docs about GenericRelation not supporting aggregation.

This works at least as far back as Django 1.6 according to the test
added in refs #10870.

comment:4 Changed 4 years ago by Tim Graham <timograham@…>

In 78f98057:

[1.9.x] Fixed #24019 -- Fixed inaccurate docs about GenericRelation not supporting aggregation.

This works at least as far back as Django 1.6 according to the test
added in refs #10870.

Backport of e19bd086d608c981098130a49e406de91dcc3d26 from master

comment:5 Changed 4 years ago by Tim Graham <timograham@…>

In 5adeb41:

[1.8.x] Fixed #24019 -- Fixed inaccurate docs about GenericRelation not supporting aggregation.

This works at least as far back as Django 1.6 according to the test
added in refs #10870.

Backport of e19bd086d608c981098130a49e406de91dcc3d26 from master

Note: See TracTickets for help on using tickets.
Back to Top