Opened 7 years ago

Closed 7 years ago

#24017 closed Bug (fixed)

add python_2_unicode_compatible to classes in db/migrations

Reported by: Josh Schneier Owned by: Josh Schneier
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description (last modified by Josh Schneier)

i was looking into an unrelated issue and noticed that python_2_unicode_compatible wasn't applied to some classes with str db/migrations.

Change History (5)

comment:1 Changed 7 years ago by Josh Schneier

Description: modified (diff)
Status: newassigned

comment:2 Changed 7 years ago by Josh Schneier

I've created a pull request here: https://github.com/django/django/pull/3750

Let me know if I've done anything wrong, I've never contributed to django before and was trying to follow the project/contributor guidelines. I don't think this particular change needs tests and am not sure if it needs a documentation update.

comment:3 Changed 7 years ago by Tim Graham

Component: UncategorizedMigrations
Needs tests: set
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

comment:4 Changed 7 years ago by Markus Holtermann

Needs tests: unset
Patch needs improvement: set

Apart from the few comments and annotations I left on the pull request, this looks ready-for-checkin.

comment:5 Changed 7 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 9a23470072865b7aa659e6af0b275668c85bb44d:

Fixed #24017 -- Added python_2_unicode_compatible in db/migrations

Note: See TracTickets for help on using tickets.
Back to Top