Opened 9 years ago

Last modified 9 years ago

#23996 new New feature

Allow AlterOrderWithRespectTo to order existing data

Reported by: Markus Holtermann Owned by:
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Markus Holtermann Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Following #23983 it might be worth it to add a flag to AlterOrderWithRespectTo to order existing data (off by default for backwards compat and as this might cause serious performance problems on large tables). The MigrationQuestioner could then ask (and warn) for that flag.

Change History (7)

comment:1 Changed 9 years ago by mhall1

Owner: changed from nobody to mhall1
Status: new → assigned

comment:2 Changed 9 years ago by mhall1

Triage Stage: Unreviewed → Accepted

comment:3 Changed 9 years ago by mhall1

I apologize but I have to release this ticket because I'm leaving on vacation and its still waiting for approval by the core team.

comment:4 Changed 9 years ago by mhall1

Owner: mhall1 deleted
Status: assigned → new

comment:5 Changed 9 years ago by Tim Graham

Easy pickings: unset

@mhall1, you probably didn't realize since you marked the ticket as "Accepted" it doesn't appear in the unreviewed ticket queue to get feedback. Anyway, the ideas seems okay to me although I am not quite sure what the implementation would look like -- would the questioner iterate through all the rows and ask for an order # or something else?

comment:6 Changed 9 years ago by Markus Holtermann

I suggest to order the existing rows by the default ordering of the related model (the owrt is defined on).

comment:7 Changed 9 years ago by mhall1

Oh okay, thanks for the tip @timgraham.

Note: See TracTickets for help on using tickets.
Back to Top